Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Nov 16, 2018

We haven't needed these since we dropped the parsers in f7a4e68 (#403).

Generated with:

$ sed -i 's/ yaml:.*/`/' $(git grep -l yaml pkg/tfvars)

We haven't needed these since we dropped the parsers in f7a4e68
(pkg/types/config: Drop ParseConfig and other Parse* methods,
2018-10-02, openshift#403).

Generated with:

  $ sed -i 's/ yaml:.*/`/' $(git grep -l yaml pkg/tfvars)
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 16, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit aa39631 into openshift:master Nov 16, 2018
@wking wking deleted the drop-tfvars-yaml branch November 16, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants